Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_fillNavHeight course property is not inherited on content objects #22

Closed
swashbuck opened this issue Jan 31, 2024 · 1 comment · Fixed by #23
Closed

_fillNavHeight course property is not inherited on content objects #22

swashbuck opened this issue Jan 31, 2024 · 1 comment · Fixed by #23
Assignees
@swashbuck
Labels
bug released

Comments

@swashbuck
Copy link
Contributor

Subject of the issue

On content object pages, the navigation logo does not respect _fillNavHeight unless it's set on the content object itself.

"_navigationLogo": {
  "_isEnabled": true,
  "_fillNavHeight": true
},

I assume that we do not want to make this a content object level property, so it should be using the value set in course.json.

Steps to reproduce

  1. In course.json, configure the nav logo with "_fillNavHeight": true
  2. View the menu and then a content object page to compare the logo height

Expected behaviour

Logo heights should be uniform on the menu and content objects.
@swashbuck swashbuck added the bug label Jan 31, 2024
@swashbuck swashbuck self-assigned this Jan 31, 2024
@swashbuck swashbuck mentioned this issue Jan 31, 2024
Merged
swashbuck added a commit that referenced this issue Feb 1, 2024
@swashbuck
Fix: Inherit _fillNavHeight on content objects, change height calcula…
101670a 
…tion to use --adapt-navigation-height (fixes #22)
github-actions bot pushed a commit that referenced this issue Feb 1, 2024
@semantic-release-bot
Chore(release): 3.1.2 [skip ci]
3ff88fd 
## [3.1.2](v3.1.1...v3.1.2) (2024-02-01)

### Fix

* Inherit _fillNavHeight on content objects, change height calculation to use --adapt-navigation-height (fixes #22) ([101670a](101670a)), closes [#22](#22)
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

🎉 This issue has been resolved in version 3.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@swashbuck