Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link option to logo image #26

Closed
swashbuck opened this issue Apr 4, 2024 · 4 comments · Fixed by #27
Closed

Add link option to logo image #26

swashbuck opened this issue Apr 4, 2024 · 4 comments · Fixed by #27
Assignees
@swashbuck
Labels
enhancement released

Comments

@swashbuck
Copy link
Contributor

Subject of the enhancement

Currently, the nav logo is just a static image. It might be useful to have the ability to make this image a link. A typical use case would be to have the logo link to the main menu (a.k.a. the "home page"), which is similar to how most web sites function.

Does anyone think this would be a useful addition?
@swashbuck swashbuck changed the title Add link option to logo Add link option to logo image Apr 4, 2024
@oliverfoster
Copy link
Member

Yes please

@guywillis
Copy link
Contributor

Preliminarily, yes.

Though what would our approach be for assisted tech users?

@oliverfoster
Copy link
Member

oliverfoster commented Apr 8, 2024 •
edited
Loading

Image used alone as a linked logo
https://www.w3.org/WAI/tutorials/images/functional/#example-1-image-used-alone-as-a-linked-logo

@swashbuck swashbuck self-assigned this May 16, 2024
@swashbuck swashbuck mentioned this issue May 16, 2024
Merged
oliverfoster added a commit that referenced this issue May 17, 2024
@oliverfoster
New: Add logo link option (fixes #26)
23a9da9
github-actions bot pushed a commit that referenced this issue May 17, 2024
@semantic-release-bot
Chore(release): 3.3.0 [skip ci]
dbfa886 
# [3.3.0](v3.2.0...v3.3.0) (2024-05-17)

### New

* Add logo link option (fixes #26) ([23a9da9](23a9da9)), closes [#26](#26)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New: Add logo link option (fixes #26) cgkineo/adapt-navigationLogo
3 participants
@swashbuck @oliverfoster @guywillis