Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move u-display-none to "navigation-logo" #6

Closed
chucklorenz opened this issue Apr 24, 2022 · 2 comments · Fixed by #11
Closed

move u-display-none to "navigation-logo" #6

chucklorenz opened this issue Apr 24, 2022 · 2 comments · Fixed by #11
Assignees
@swashbuck
Labels
enhancement released

Comments

@chucklorenz
Copy link

adapt-navigationLogo v2.1.0

Currently when "_hideLogoForMobile": true, u-display-none is applied to img.navigation-logo__image. This leaves in place the parent divs and their styling. Such remnants interfere with the goal of removing the logo and recapturing space in the navbar.

I suggest that u-display-none be added to navigation-logo instead of img.navigation-logo__image.
------------------

In this first screenshot, I added a white border to navigation-logo to highlight what remains behind. These remnant divs push out of alignment the text "View Progress".
nav-logo-1

In this second screenshot, the white border remains in code but is not visible because I moved u-display-none to the parent navigation-logo. Consequently, "View Progress" falls in-line.
image
@swashbuck
Copy link
Contributor

👍 This makes sense to me.

swashbuck added a commit that referenced this issue Jan 2, 2023
@swashbuck
#6 Move u-display-none to navigation-logo when hiding for mobile
2f5135e
@swashbuck swashbuck mentioned this issue Jan 2, 2023
Merged
@swashbuck swashbuck self-assigned this Jan 2, 2023
@swashbuck swashbuck mentioned this issue Jan 3, 2023
Merged
github-actions bot pushed a commit that referenced this issue Feb 7, 2023
@semantic-release-bot
Chore(release): 3.0.1 [skip ci]
fac95d1 
## [3.0.1](v3.0.0...v3.0.1) (2023-02-07)

### Fix

* ES6/JSX conversion and schema AAT update (fixes #6 #8 #9 #10) ([6ad1f57](6ad1f57)), closes [#6](#6) [#8](#8) [#9](#9) [#10](#10)
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Convert to React / ES6 (fixes #10) cgkineo/adapt-navigationLogo
2 participants
@swashbuck @chucklorenz