This repository was archived by the owner on Jul 2, 2021. It is now read-only.
add VOC instance segmentation evaluation #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knorth55
force-pushed
the
eval-inst-voc
branch
3 times, most recently
from
d37b7ec to
b89995a
Compare
yuyu2172
reviewed
Apr 4, 2018
| 'voc_instance_segmentation_result_test_2018_04_04.npz'))[0], | ||
| encoding='latin1') | ||
|
|
||
| def test_eval_detection_voc(self): |
There was a problem hiding this comment.
test_eval_instance_segmentation_voc
| @classmethod | ||
| def setUpClass(cls): | ||
| base_url = 'https://github.com/knorth55/' \ | ||
| 'share-weights/releases/download/v0.0.0' |
There was a problem hiding this comment.
I added you to a maintainer of yuyu2172/share-weights
| dataset. Each element of :obj:`pred_masks` is an object mask | ||
| and is an array whose shape is :math:`(R, H, W)`, | ||
| where :math:`R` corresponds | ||
| to the number of masks, which may vary among imagse. |
|
|
||
| pred_labels = iter(pred_labels) | ||
| pred_scores = iter(pred_scores) | ||
| gt_labels = iter(gt_labels) |
| dataset. Each element of :obj:`pred_masks` is an object mask | ||
| and is an array whose shape is :math:`(R, H, W)`, | ||
| where :math:`R` corresponds | ||
| to the number of masks, which may vary among imagse. |
| length is :math:`N`. | ||
| iou_thresh (float): A prediction is correct if its Intersection over | ||
| Union with the ground truth is above this value. | ||
| use_07_metric (bool): Whether to use PASCAL VOC 2007 evaluation metric |
There was a problem hiding this comment.
I think the default value should be False to be consistent with eval_detection_voc
There was a problem hiding this comment.
OK, I set as default False
| selec[gt_idx] = True | ||
| else: | ||
| match[l].append(0) | ||
|
|
There was a problem hiding this comment.
I think it is same to insert error check like eval_detection_voc
https://github.com/chainer/chainercv/blob/master/chainercv/evaluations/eval_detection_voc.py#L214
yuyu2172
approved these changes
Apr 5, 2018
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eval_instance_segmentation_voctest_eval_instance_segmentation_voceval_instance_segmentation_voc