RPC only explorer #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a way to run MultiChain Explorer without access to the node data directory:
dirnamein config can be set to anything, e.g./foo/bar(can be potentially eliminated at all but requires refactoring)Observation
chain-nameparameter is currently empty in API calls (save_blkfile_offset()is not executed ->datadirtable is empty ->get_multichain_name_by_id()returnsNone). Looks like it works perfectly in any of 3 scenarios:chain-nameWas it ever required? Checked the oldest node
ND-241-981-577running2.0-beta-1, all the same.