Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Hotfix 864 #866

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Hotfix 864 #866

merged 3 commits into from
Mar 31, 2022

Conversation

rjdp
Copy link
Contributor

@rjdp rjdp commented Mar 31, 2022

resolves #864

as well as :

  • earlier (pre 0.5.0) few datasource capabilities (like supported aggregations) were hardcoded on frontend , we had moved in 0.5.0 to a backend api
  • we had tested only non-3rd party and missed handling incase datasource is 3rd party

@netlify
Copy link

netlify bot commented Mar 31, 2022

Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit 39cfa88
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/6245bf7b43bbd1000857eb48

@rjdp rjdp requested a review from Samyak2 March 31, 2022 09:11
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjdp rjdp requested a review from Samyak2 March 31, 2022 14:51
@Samyak2 Samyak2 linked an issue Mar 31, 2022 that may be closed by this pull request
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjdp rjdp merged commit 4d6d16d into develop Mar 31, 2022
@Samyak2 Samyak2 deleted the hotfix-864 branch April 21, 2022 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KPI form does not populate tables when using third-party datasources
3 participants