Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

fix(editkpi): issue of subdim anomaly failure after removal of all subdims #939

Merged
merged 1 commit into from
Apr 29, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion chaos_genius/views/kpi_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@
jsonify,
)
import pandas as pd
from chaos_genius.connectors import get_sqla_db_conn
from sqlalchemy.orm.attributes import flag_modified

from chaos_genius.connectors import get_sqla_db_conn
from chaos_genius.controllers.kpi_controller import (
delete_anomaly_output_for_kpi,
delete_rca_output_for_kpi,
Expand Down Expand Up @@ -314,6 +315,28 @@ def edit_kpi(kpi_id):
run_analytics = True
if chech_editable_field(meta_info, key):
setattr(kpi_obj, key, value)
# check if dimensions are editted
if "dimensions" in data.keys():
# if empty, do not run anomaly on subdim
if len(data["dimensions"]) < 1:
run_optional = {
"data_quality": True,
"overall": True,
"subdim": False
}
else:
run_optional = {
"data_quality": True,
"overall": True,
"subdim": True
}

if "run_optional" not in kpi_obj.anomaly_params or \
run_optional["subdim"] != kpi_obj.anomaly_params["run_optional"]["subdim"]:
kpi_obj.anomaly_params["run_optional"] = run_optional
flag_modified(kpi_obj, "anomaly_params")


if run_analytics:
logger.info(
"Deleting analytics output and re-running tasks since KPI was "
Expand Down