Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

fix(edit-kpi): issue #965 of dashboard getting reset to All after editing a KPI. #966

Merged
merged 3 commits into from
May 26, 2022
Merged

fix(edit-kpi): issue #965 of dashboard getting reset to All after editing a KPI. #966

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63b33e6
fix(edit-kpi): issue #965
varunp2k May 26, 2022
3dd9a95
fix(edit-kpi): removed redundant .keys()
varunp2k May 26, 2022
683c8e8
fix(edit-kpi): moved dashboard function calls
varunp2k May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions chaos_genius/views/kpi_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,6 @@ def edit_kpi(kpi_id):

meta_info = Kpi.meta_info()
if kpi_obj and kpi_obj.active is True:
dashboard_id_list = data.pop("dashboards", []) + [0]
dashboard_id_list = list(set(dashboard_id_list))

for key, value in data.items():
if key not in do_not_run_analytics_list:
run_analytics = True
Expand Down Expand Up @@ -451,7 +448,11 @@ def edit_kpi(kpi_id):
+ f"editing: {kpi_id}"
)

edit_kpi_dashboards(kpi_id, dashboard_id_list)
if "dashboards" in data:
dashboard_id_list = data.pop("dashboards", []) + [0]
dashboard_id_list = list(set(dashboard_id_list))
edit_kpi_dashboards(kpi_id, dashboard_id_list)

kpi_obj.save(commit=True)
status = "success"
else:
Expand Down