Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

DeepDrills Decoupling and Restructuring #967

Merged
merged 7 commits into from
May 31, 2022
Merged

DeepDrills Decoupling and Restructuring #967

merged 7 commits into from
May 31, 2022

Conversation

kartikay-bagla
Copy link
Contributor

  • Backend Changes
    • Trigger DD only if env var DEEPDRILLS_ENABLED is true
    • Renamed relevant env vars from DeepDrills to Summary or KPI

@kartikay-bagla
style(settings): formatted settings.py
e2e5f1c
@kartikay-bagla
style(settings): fixed import order settings.py
64fecd6
@kartikay-bagla
style(kpi,rca): fix formatting
fd73144
@kartikay-bagla
feat(rca): decoupled RCA
c8d3f78 
* DEEPDRILLS_ENABLED now decides if DeepDrills is computed
* Renamed few env vars for clarity
* Formatted files
@gitpod-io
Copy link

gitpod-io bot commented May 27, 2022

@netlify
Copy link

netlify bot commented May 27, 2022 •
edited
Loading

✅ Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit f5b2ab9
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/6295fb924a70af0008826e12

@kartikay-bagla kartikay-bagla changed the base branch from main to develop May 27, 2022 06:57
@kartikay-bagla
feat(summary): separated and created summary module
2298d54 
* moved summary to a separate endpoint
* added anomaly count to aggregations
* added error messages for RCA API if DEEPDRILLS_ENABLED is false.
@kartikay-bagla kartikay-bagla requested a review from Samyak2 May 31, 2022 07:57
@kartikay-bagla kartikay-bagla marked this pull request as ready for review May 31, 2022 07:58
Samyak2
Samyak2 reviewed May 31, 2022
View reviewed changes
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are changes in the .env, we should communicate that these are breaking changes. For example, if a user had overridden MAX_DEEPDRILLS_SLACK_DAYS to a different value in .env (or in a separate .env.local), they'll need to set the value for MAX_SUMMARY_DEEPDRILLS_SLACK_DAYS or rename it to that before upgrading. If not done, it will appear as if some settings got reset to their defaults.

A short upgrade/migration guide should suffice here. It should list all the steps needed to successfully upgrade to v0.8.0.

Samyak2
Samyak2 suggested changes May 31, 2022
View reviewed changes
@Samyak2
Copy link
Contributor

Samyak2 commented May 31, 2022

Checked docker compose files, everything looks consistent 👍

@kartikay-bagla
fix(summary): applied changes in review comments
f5b2ab9 
* fixed isort import error
* fixed datte range for anomaly summary
* fixed docstring
Samyak2
Samyak2 approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kartikay-bagla kartikay-bagla merged commit 522bb66 into develop May 31, 2022
@kartikay-bagla kartikay-bagla deleted the feature/dd_restructuring branch May 31, 2022 11:36
@Samyak2 Samyak2 added this to the v0.8.0 milestone Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Samyak2 Samyak2 Samyak2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kartikay-bagla @Samyak2