This repository was archived by the owner on Sep 12, 2024. It is now read-only.
fix(connectors): updated quoted identifier strings #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for frontend-sb canceled.
|
kartikay-bagla
added
🐛 bug
manassolanki
reviewed
Jun 9, 2022
manassolanki
reviewed
Jun 9, 2022
| + f"""'{end_date.strftime("%Y-%m-%d")}T00:00:00+05:30'""" | ||
| assert output_query == dl._build_query().strip() | ||
|
|
||
| # test for snowflake |
There was a problem hiding this comment.
Some feedback for the future (can be added as TODO)
- Most of this code feels repetitive. This can be made a generic function and then a list of test case input and output can be passed to have the test cases. In that way, you can easily add more than one test case for a single data source.
- We can add 3-4 more test cases for the snowflake to be sure that we have covered the majority of test cases.
manassolanki
approved these changes
Jun 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: