Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Fixes #991 by checking for validation sucess before running checks for tz-aware data #992

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Fixes #991 by checking for validation sucess before running checks for tz-aware data #992

merged 2 commits into from
Jun 16, 2022

Conversation

kartikay-bagla
Copy link
Contributor

Fixes #991

@kartikay-bagla kartikay-bagla added the 🐛 bug Something isn't working label Jun 15, 2022
@kartikay-bagla kartikay-bagla added this to the v0.9.0 milestone Jun 15, 2022
@kartikay-bagla kartikay-bagla requested a review from varunp2k June 15, 2022 13:33
@gitpod-io
Copy link

gitpod-io bot commented Jun 15, 2022

@netlify
Copy link

netlify bot commented Jun 15, 2022 •
edited
Loading

✅ Deploy Preview for frontend-sb ready!

Name Link
🔨 Latest commit 886b236
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62a9dfb162130a000785abb2
😎 Deploy Preview https://deploy-preview-992--frontend-sb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kartikay-bagla
Copy link
Contributor Author

@varunp2k you only need review the second commit, the first is just a formatting commit for the kpi_validation.py file.

@varunp2k
Copy link
Member

varunp2k commented Jun 16, 2022 •
edited
Loading

  • Tested it on dev-main.
  • Added country for the AOV KPI in the datetime column.
  • Edited datetime column to country in an already setup AOV kpi.
  • It works as expected.

LGTM

@varunp2k varunp2k merged commit eba6535 into develop Jun 16, 2022
@Amatullah Amatullah deleted the fix/kpi-validation-check-tz-aware-bug branch June 30, 2022 05:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@varunp2k varunp2k varunp2k approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kartikay-bagla @varunp2k