Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genius reverse dependency to CRAN #112

Closed
JosiahParry opened this issue May 6, 2020 · 12 comments
Closed

genius reverse dependency to CRAN #112

JosiahParry opened this issue May 6, 2020 · 12 comments

Comments

@JosiahParry
Copy link
Collaborator

If I don't commit or comment by Sunday morning please annoy me about it.

@JosiahParry
Copy link
Collaborator Author

Submitted to CRAN. Forgot title case....of course. Should be accepted soon.

@jeffrey-price
Copy link

This may be a dumb question, but what is a reverse dependency and will this correct the error:
"Error: Failed to install 'spotifyr' from GitHub:
(converted from warning) package ‘genius’ is not available (for R version 4.0.0)"?

@JosiahParry
Copy link
Collaborator Author

this is my fault. Working to fix that right now. genius is currently in the CRAN gods' hands right now. In essence some of the functions inside of spotifyr require functions from genius. You can install genius with remotes::install_github("josiahparry/genius"). Then remotes::install_github("charlie86/spotifyr")

@rafabelokurows
Copy link

I was to able to install "genius" then "spotifyr" through these commands a few days back, just had to manually update the version of some other libraries which were not up to date.
When I tried installing genius, I kept getting the message: "package xxx is in version 0.1 it should be on 0.2", stuff like that. So I updated each one manually, installed genius and then installed spotifyr.
But I don't mean to complain, or anything, I'm just saying that there was/is a workaround :)
BTW, thanks for all your effort on this, Josiah and Charlie! I really appreciate the libraries and all the work you guys have put into them!

@JosiahParry
Copy link
Collaborator Author

Thanks @rafabelokurows! I'm so sorry for the headache!

@JosiahParry
Copy link
Collaborator Author

JosiahParry commented May 10, 2020

Update: genius has a dependency on tidyr which has a dep on ellipsis. ellipsis suddenly is failing builds on CRAN checks (see r-lib/ellipsis#33). Which means this will be delayed until above is addressed

@rafabelokurows
Copy link

that was no problem at all, @JosiahParry... I managed to install it just fine and now I'm playing around with some visualizations based on Foo Fighters songs 🎧🎸🤘🏻 hope the issue is resolved soon! :)

@JosiahParry
Copy link
Collaborator Author

reverse dependency build error from r-lib/ellipsis#33 has been solved. Resubmitting genius to CRAN.

@chris-billingham
Copy link

@JosiahParry How did the submission go?

@JosiahParry
Copy link
Collaborator Author

@chris-billingham currently pending manual inspection! 🤞

@JosiahParry
Copy link
Collaborator Author

On it's way to CRAN!

@JosiahParry
Copy link
Collaborator Author

JosiahParry commented May 28, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants