Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package archived in CRAN #119

Closed
harshvardhaniimi opened this issue Jun 15, 2020 · 14 comments
Closed

package archived in CRAN #119

harshvardhaniimi opened this issue Jun 15, 2020 · 14 comments

Comments

@harshvardhaniimi
Copy link

The package isn't available on CRAN anymore because of some outdated packages. Please check if something could be done about it.
Also, please add a list of all functions - something like documentation. That'd really help. Great work by the way!

@andodet
Copy link

andodet commented Jun 18, 2020

Not the mantainer here. You can find documentation here or by ??spotifyr in your R console.

@harshvardhaniimi
Copy link
Author

There are more functions than what are mentioned on the blog you mentioned. Also ??spotifyr doesn't work.

@andodet
Copy link

andodet commented Jun 18, 2020

My bad for not checking thoroughly. That documentation is compiled with {pkgdown} outside of github so I have no idea when was the last time it was updated.

CRAN is probably complaining for some dplyr deprecation warnings I've encountered as well when working on a fork.

@charlie86 It'd be probably good to move it on a gh-pages branch with a simple Github Action for simple deployment (here for more on this) to avoid having to do it manually each time docs are update or a function is added.

@harshvardhaniimi
Copy link
Author

Sorry for the late reply: I downloaded the source codes of the package and thankfully they were detailed enough. That worked for me.

@niessen
Copy link
Contributor

niessen commented Jul 2, 2020

The problem which led to archiving has been resolved ( #112), so this issue could probably be fixed by resubmitting to CRAN.

@andodet
Copy link

andodet commented Jul 28, 2020

@charlie86 Looping you in this one as I believe that resubmitting spotifyr to CRAN would benefit many users and avoid workarounds for applications depending on it.

@r-leyshon
Copy link

As on the CRAN website

"Archived on 2020-05-03 as requires archived package 'genius'."

Keen to know if this will be remedied any time soon.

@antaldaniel antaldaniel added this to the New minor CRAN release milestone Jun 9, 2021
@antaldaniel
Copy link
Collaborator

@JosiahParry , is a hard dependency necessary, cannot genius only be suggested?

@JosiahParry
Copy link
Collaborator

@antaldaniel It can be suggested. No hard requirement. Was it taken off of CRAN?

@antaldaniel
Copy link
Collaborator

@JosiahParry Yes, it was. It's been a long time since the last release, and I think that the most labourous issue is broken links in the documentation. But also, if a dependency is taken down from CRAN, it pulls down all downstream packages, and therefore only actively maintained packages should remain hard dependencies. (I think it was not genius that pulled down spotifyr, but ggjoy in the README, which is superseded by ggridges; but anyway, you either maintain actively genius, or it shoudl be suggested.)

I am not sure how much effort it will take to get the package back to CRAN, by the way. The biggest challenge is that they do not accept \dontrun{} anymore, only \donttest{}, and all the examples require Spotify Web API authorization. But I am looking into how other API wrapper packages solve this.

@JosiahParry
Copy link
Collaborator

Yes, that issue was resolved nearly a year ago.

I presently maintain genius. I too am going through the challenges associated with changes to CRAN.

All examples in spotifyr should be wrapped in donttest{}. This will ensure that CRAN checks do not try and test the functions and error with non-zero exit.

@JosiahParry
Copy link
Collaborator

Addtionally, I'd recommend that the README be included in the .Rbuildignore.

@antaldaniel
Copy link
Collaborator

@JosiahParry Thanks, I was just working on updating the genius functions. They are heavily affected by changes in tibble, and the .Rbuildignore is updated. I'd like to get in touch with you about genius. I'll send you message or leave a note there.

@JosiahParry
Copy link
Collaborator

@antaldaniel please do open an issue if you find any issues. There are none related to tibble presently that I am aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants