Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling value before rendering #30

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Fix styling value before rendering #30

merged 2 commits into from
Feb 27, 2023

Conversation

aymanbagabas
Copy link
Member

Fixes: #19

tombell and others added 2 commits February 27, 2023 12:33
* fix(text) escape value before rendering style

* fix(text) render value style before escaping

* test(text) add additional test cases
Fixes: cddf0df ("fix(text) escape value before rendering styles (#20)")
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #30 (d58665b) into main (462efd0) will increase coverage by 3.55%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   51.40%   54.95%   +3.55%     
==========================================
  Files          23       23              
  Lines         714      726      +12     
==========================================
+ Hits          367      399      +32     
+ Misses        331      313      -18     
+ Partials       16       14       -2     
Impacted Files Coverage Δ
text.go 57.06% <88.88%> (+11.13%) ⬆️
styles.go 42.85% <0.00%> (+42.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aymanbagabas aymanbagabas merged commit cc3834d into main Feb 27, 2023
@aymanbagabas aymanbagabas deleted the fix-value-style branch February 27, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escaped escape codes when overriding ValueStyle and value needs quoting
2 participants