Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore hidden headers in IMF section #6620

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

iequidoo
Copy link
Collaborator

@iequidoo iequidoo commented Mar 6, 2025

Hidden headers are nonstandard, so they aren't DKIM-signed by e.g. OpenDKIM if they appear in IMF section.

@iequidoo
Copy link
Collaborator Author

iequidoo commented Mar 6, 2025

CFFI Python tests fail because this fix depends on #6610 (currently "Chat-Group-Avatar" isn't hidden). But this only matters for unencrypted messages, maybe we can just merge #6610 and drop support of setting group avatars using legacy IMF header?

EDIT: #6610 is merged.

@iequidoo iequidoo force-pushed the iequidoo/unencrypted-del-requests branch 2 times, most recently from 3705baf to 1604f20 Compare March 11, 2025 02:23
@iequidoo iequidoo marked this pull request as draft March 11, 2025 02:33
Base automatically changed from iequidoo/unencrypted-del-requests to main March 11, 2025 22:54
@iequidoo iequidoo force-pushed the iequidoo/chat-edit,delete branch from 0a7bff6 to 5c2ccdd Compare March 11, 2025 23:13
@iequidoo iequidoo marked this pull request as ready for review March 11, 2025 23:15
@iequidoo iequidoo requested review from link2xt and r10s March 11, 2025 23:22
Hidden headers are nonstandard, so they aren't DKIM-signed by e.g. OpenDKIM if they appear in IMF
section.
@iequidoo iequidoo force-pushed the iequidoo/chat-edit,delete branch from 5c2ccdd to a83c10b Compare March 12, 2025 01:05
@iequidoo iequidoo merged commit c12c4f6 into main Mar 12, 2025
28 of 29 checks passed
@iequidoo iequidoo deleted the iequidoo/chat-edit,delete branch March 12, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants