Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match any kernel version in debian purge command #1490

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Match any kernel version in debian purge command #1490

merged 2 commits into from
Mar 22, 2023

Conversation

upekkha
Copy link
Contributor

@upekkha upekkha commented Mar 13, 2023

The cleanup_debian.sh script was only removing kernel versions starting with [234] and thus not matching the current kernel versions 5 or 6. This PR suggests to match any version [1-9].

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@upekkha upekkha requested review from a team and Stromweld as code owners March 13, 2023 06:41
@Stromweld
Copy link
Collaborator

Have you tested this change? My only concern is that it'll remove all linux-image packages even for the current kernel.

@upekkha
Copy link
Contributor Author

upekkha commented Mar 22, 2023

I locally tested with Debian 10, 11 and upcoming 12. The currently running kernel is anyway excluded by the grep -v "$(uname -r)" on the next line.

@Stromweld
Copy link
Collaborator

gotcha I see it now. makes sense thanks.

Stromweld
Stromweld approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@Stromweld Stromweld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stromweld Stromweld enabled auto-merge (squash) March 22, 2023 14:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Stromweld Stromweld merged commit 647d206 into chef:main Mar 22, 2023
raykrist pushed a commit to norcams/bento that referenced this pull request Aug 19, 2024
@upekkha @raykrist
match any kernel version in debian purge command (chef#1490)
58122a6 
Signed-off-by: Claude Becker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stromweld Stromweld Stromweld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@upekkha @Stromweld