1.7.1 #880
Merged
1.7.1 #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In compose/env file, set `CCAT_CORE_USE_SECURE_PROTOCOLS=0` issue: `get_base_url()` will return `http0://...` This commit rewrites the condition in order to get the expected behavior: - `CCAT_CORE_USE_SECURE_PROTOCOLS=1 | true` will give `https://...` - everything else will give `http://...`
fix: CCAT_CORE_USE_SECURE_PROTOCOLS
- setup the cat with an https nginx proxy - when using `/rabbithole` endopint, or any endopint that makes a redirect, fastapi/uvicorn will downgrade the connection to `http` because of the missing uvicorn server flags - in case the original connection is https this will trigger the following error: ``` Mixed Content The page at was loaded over HTTPS but requested an insecure resource This request has been blocked the content must be served over HTTPS ``` - add new environment variable `CCAT_HTTPS_PROXY_MODE` in order to add the required flags when needed fastapi/fastapi#9328 (comment)
with this fix it is now possible to update the password of an user. Admin user is still not editable, so also the password cannot be changed.
fix: change user password
add: new env variables to manage https proxy pass
derogab
added a commit
to derogab/umbrel-app-store
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New in 1.7.1
CCAT_HTTPS_PROXY_MODEenv variable - @kodaline/publicendpoint - @pieroit