Completed Issue #573 To Mark a job post as filled

[HugoSeguin]

No description provided.

[elmq0022]

Please revert the settings.py file.

[elmq0022]

Please remove all the changes related to the flatpages and move them to a different PR as discussed.

[elmq0022]

I like the changes related to the job post model and the related migration.

I didn't look into it, but how will django handle the old job posting in that don't have a filled status or filled date?

Will users be able to edit their job filed status / date. Is that available in the user facing edit form and not just the admin. Most users will not have access to the admin.

Please remove the ability to see a list of filled jobs as the AC was optional. I think it's fine to do, but we should have a separate template and view for that. Let's skip for now so we can close this PR.

Please revert all other changes as noted.

[eevelweezel]

Re: django and old posts... Can we add logic in the migrations to set a status for the old records?

…

On Thu, Mar 13, 2025, 19:55 elmquist.dev ***@***.***> wrote: I like the changes related to the job post model and the related migration. I didn't look into it, but how will django handle the old job posting in that don't have a filled status or filled date? Will users be able to edit their job filed status / date. Is that available in the user facing edit form and not just the admin. Most users will not have access to the admin. Please remove the ability to see a list of filled jobs as the AC was optional. I think it's fine to do, but we should have a separate template and view for that. Let's skip for now so we can close this PR. Please revert all other changes as noted. — Reply to this email directly, view it on GitHub <#595 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABHKYUBQVLFPXIRYWN4ZYE32UISGPAVCNFSM6AAAAABYPLBBQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRTGA2DEMZQGU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> [image: elmq0022]*elmq0022* left a comment (chicagopython/chipy.org#595) <#595 (comment)> I like the changes related to the job post model and the related migration. I didn't look into it, but how will django handle the old job posting in that don't have a filled status or filled date? Will users be able to edit their job filed status / date. Is that available in the user facing edit form and not just the admin. Most users will not have access to the admin. Please remove the ability to see a list of filled jobs as the AC was optional. I think it's fine to do, but we should have a separate template and view for that. Let's skip for now so we can close this PR. Please revert all other changes as noted. — Reply to this email directly, view it on GitHub <#595 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABHKYUBQVLFPXIRYWN4ZYE32UISGPAVCNFSM6AAAAABYPLBBQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRTGA2DEMZQGU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>