-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support serializing timedelta and relativedelta to string (hocon, json etc.) #263
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a826b18
added support for serializing timedelta and relativedelta
5c741cc
added support for serializing timedelta and relativedelta - revert wh…
6d6c894
added support for serializing timedelta and relativedelta - removed p…
1e3ce91
added support for serializing timedelta and relativedelta - reduce py…
b466704
added support for serializing timedelta and relativedelta - reduce py…
b7d6161
added support for serializing timedelta and relativedelta - remove py…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pyhocon supports multiple input formats for timedelta, like:
But output format is fixed,and thus some applications expecting format other than this one will fail while parsing output config.
For example, Spark config values could contain time units like
150ms
, but converter will save it as150000 microseconds
(there is just no case for milliseconds).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dolfinus
output is specifically for hocon format. if spark config is different then it is not hocon and requires it's own output. don't know if it's in the scope of this library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see here any specification about default unit format - all the options are described as supported by a parser. There is no preferred unit format, so why does implementation have one without any capability to change it whenever user wants?
Spark config is just the simple
.properties
file which is successfully read by any HOCON library implementation. But the output file saved by the current package cannot be changed at all - no class or instance options for setting up some preferred format.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dolfinus
"so why does implementation have one without any capability to change it whenever user wants?" - because that is the implementation I submitted.
"Spark config is just the simple .properties" - so it's not hocon.
"file which is successfully read by any HOCON library implementation" - I do believe you are free to contribute code which enhances this library to your additional requirements. That's what I did.
ps.
From my perspective, you are coming off a bit demanding, considering this is open-source and based on free contributions from people who care enough to do so. less talk, more code :)