Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: address some new warnings, squelch others. #2086

Merged
merged 1 commit into from
Jan 31, 2024
Merged

clang-tidy: address some new warnings, squelch others. #2086

merged 1 commit into from
Jan 31, 2024

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Jan 30, 2024

The previous clang-tidy settings were for clang-tidy-14, this prepares for all clang-tidy-17 warnings to be addressed (or ignored).

For now, we just run with tidy 15 on CI.

The previous clang-tidy settings were for clang-tidy-14, this
prepares for all clang-tidy-17 warnings to be addressed (or
ignored).

For now, we just run with tidy 15 on CI.
@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (31182be) 92.96% compared to head (9f3f86a) 92.92%.
Report is 2 commits behind head on master.

Files Patch % Lines
common/formatting/align.cc 0.00% 2 Missing ⚠️
common/strings/patch.cc 0.00% 2 Missing ⚠️
...nalysis/checkers/truncated_numeric_literal_rule.cc 0.00% 2 Missing ⚠️
...nalysis/checkers/undersized_binary_literal_rule.cc 0.00% 2 Missing ⚠️
verilog/analysis/flow_tree.cc 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2086      +/-   ##
==========================================
- Coverage   92.96%   92.92%   -0.04%     
==========================================
  Files         358      358              
  Lines       26563    26582      +19     
==========================================
+ Hits        24693    24701       +8     
- Misses       1870     1881      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hzeller hzeller requested a review from fangism January 30, 2024 15:37
@hzeller hzeller merged commit 6cab454 into chipsalliance:master Jan 31, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants