Optimize DependsOn(); also documnt #2099 #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The weak ordering issue needs to be addressed, but for now, just document it. Issues: #2099
…EBUG We have internal check functions for data structure consistency. Tests for these are flagged by _GLIBCXX_DEBUG, so disable them.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2100 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 358 358
Lines 26571 26571
=======================================
Hits 24688 24688
Misses 1883 1883 ☔ View full report in Codecov by Sentry. |
It is not quite ready yet to be permanently enabled though. Issues #1056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The weak ordering issue needs to be addressed, but for now, just document it.
Issues: #2099