IWYU: Fix some missing includes (string, string_view, logging, Symbol, NodeEnum) #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2106 +/- ##
=======================================
Coverage 92.92% 92.92%
=======================================
Files 358 358
Lines 26577 26577
=======================================
Hits 24696 24696
Misses 1881 1881 ☔ View full report in Codecov by Sentry. |
hzeller
changed the title
hzeller
changed the title
fangism
approved these changes
Feb 13, 2024
Also, annotate the includes in logging.h to be exporting, so that clang-tidy accepts that it is ok to get CHECK, LOG, VLOG, etc. from that header instead of including the original ones.
If someone used one of the related includes, no need to include the whole other underlying includes.
That check is not 'clean' yet, but it is useful to look for in local runs of clang-tidy. Disabled in the CI as we don't want to it to complain there quite yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.