-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add self hosted aws gpu testing #580
Conversation
@mjw99 I thought you would want to take a look at this one, please as any questions you have about how this works! I'd like to start using this as a template to adding GPU testing to other repos, so I'd like to add comments explaining what is going on in the file. |
Also, in order to really test this and see what fails we will need to merge it, but I'd like to wait to do that until we get this file documented! |
Hi Mike, Generally looks good. I would pin the version of Ubuntu at 20.04 since 22.04 has just arrived; you probably do not want this to latently change whilst you're initially testing this. Also actions/checkout is now at version 3. Also, one super minor thing in devtools/conda-envs/test_env.yaml , it seems to have cython quoted twice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mike,
Generally looks good.
I would pin the version of Ubuntu at 20.04 since 22.04 has just arrived; you probably do not want this to latently change whilst you're initially testing this. Also actions/checkout is now at version 3. Also, one super minor thing in devtools/conda-envs/test_env.yaml , it seems to have cython quoted twice
Good idea! Github is kinda slow when rolling these updates out, but I rather not worry about it actions/runner-images#5490 |
Also I know this makes the diff messy, but I sorted the packages in each section so it is easier to catch dupes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sweet! I expect something to fail post merge, I might have to add the PAT to this repo, but I think it's better to see what fails and fix it iteratively |
Hmmm on merge; I'm seeing: Are the relevant AWS secrets set OK on the master? |
Not sure what you mean, it looks like I will need to add They are set correctly in the repo that is currently using this yaml file https://github.com/choderalab/perses/ |
I think I know what you mean, no these are not set OK on master so it will fail until I add them, which I will do right now. |
Description
Resolves: #560
I'm sure some secrets will be missing, which we can make org secrets instead of repo secrets so we can use this in other repos
Todos
Status