Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Tags #766

Merged
merged 9 commits into from
Feb 12, 2025
Merged

Add AWS Tags #766

merged 9 commits into from
Feb 12, 2025

Conversation

mikemhenry
Copy link
Contributor

Description

MSK now requires mandatory tags for AWS resources.

Todos

  • Implement feature / fix bug
  • Add tests
  • Update documentation as needed
  • Update changelog to summarize changes in behavior, enhancements, and bugfixes implemented in this PR

Status

  • Ready to go

Changelog message


Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (9043f8a) to head (3e0c455).
Report is 1 commits behind head on main.

Additional details and impacted files

…ation) when calling the RunInstances operation: For 'cost-center', use the capitalization specified by the tag policy.
…ation) when calling the RunInstances operation: For 'env', use the capitalization specified by the tag policy.
…ation) when calling the RunInstances operation: For 'owner-email', use the capitalization specified by the tag policy.
@mikemhenry mikemhenry requested a review from ijpulidos January 15, 2025 02:05
@mikemhenry mikemhenry marked this pull request as ready for review January 15, 2025 02:05
@mikemhenry
Copy link
Contributor Author

@ijpulidos The action fails due something wrong with the drivers on the AMI (or maybe the wrong cuda package is pulled in) BUT this PR does add the necessary tags required by MSK, so we can get the CI action fixed in another PR.

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikemhenry mikemhenry merged commit 8a097f0 into main Feb 12, 2025
22 checks passed
@mikemhenry mikemhenry deleted the feat/add-aws-tags branch February 12, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants