Performance optimization: SendAsync: call TrySend within Task #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #48
Calling TrySend asynchronously (within new Task) to match the behavior of CppServer.
Benchmark results before:
Benchmark results after:
Before applying this fix, the _sendBufferFlush data size that was sent using SendAsync in the benchmark was constant size = 32 very low comparing to CppServer, where I had 6 digit sizes:
That caused that the NetCoreServer sent single TCP packets with 32 bytes of data each, but the CppServer sent packets with much bigger sizes (max TCP packet sizes). It seems that without this fix, sending buffered data (multiple messages in
_sendBufferFlush
) was not properly working when calling SendAsync in a loop in single-thread