Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Pascal casing #18

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

legopiraat
Copy link
Contributor

@legopiraat legopiraat commented Oct 28, 2019

Hi, with this pull request support for PascalCasing is added.
I ran into the case an external API was sending me PascalCased JSON and i was unable to parse it.
So I wrote this helper method to do this automatically.

Example:

{
 "Hello": "world"
}

case class Hello(hello: String)  // Will be parsed to Hello(world)

Somehow one test is failing and I have no idea why. Some help is appreciated there.
I did a local release and the code does work in my app.

@legopiraat legopiraat marked this pull request as ready for review October 28, 2019 19:34
@gannicottb
Copy link

Shame this PR stalled, I could use PascalCase support in my project.

@travisbrown
Copy link
Member

I thought I had reviewed this, but apparently I didn't actually post it?

I think the test failure is because the test uses lowercase for single-character member names, while the transformation capitalizes them. I don't remember what the standard expectation is for single-character names in Pascal case, but would be happy to merge this if someone makes a case either way and fixes the test.

@zarthross zarthross force-pushed the legopiraat/add-pascal-casing-support branch from 8d9bf36 to ec48c83 Compare October 22, 2022 00:21
@zarthross zarthross requested a review from zmccoy October 22, 2022 00:22
@zarthross zarthross merged commit 4a0b6d4 into circe:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants