Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly check specified discriminator for strict decoding #217

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

jatcwang
Copy link
Contributor

Fixes #216

@codecov-commenter
Copy link

Codecov Report

Base: 84.04% // Head: 84.04% // No change to project coverage 👍

Coverage data is based on head (3d05f8d) compared to base (4aa8d96).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 3d05f8d differs from pull request most recent head 1d5f140. Consider uploading reports for the commit 1d5f140 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   84.04%   84.04%           
=======================================
  Files          19       19           
  Lines         282      282           
  Branches        6        8    +2     
=======================================
  Hits          237      237           
  Misses         45       45           
Impacted Files Coverage Δ
...ce/generic/extras/decoding/ConfiguredDecoder.scala 88.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zarthross zarthross requested a review from zmccoy October 22, 2022 00:22
@zarthross zarthross merged commit b3bf2a6 into circe:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect strict decoding + transformConstructorNames behaviour
4 participants