-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation of plugin #1
Conversation
I recommend you include it as a But it's not really a burden to setup: couple lines of sbt and an |
A, correct. I knew that, but it somehow didn't register :D will include site plugin as well then |
In the longterm I think it's best to get onto sbt-typelevel proper (instead of the ci-release+settings combo). The only new thing it adds is license headers (which can be made to go away if they are truly that awful). |
Co-authored-by: Arman Bilge <[email protected]>
Now possible due to dropping scalastyle which brought in a binary incompatible downstream dep
Make sure to run |
2c638f8
to
0ddf2ba
Compare
Co-authored-by: Arman Bilge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me... @armanbilge ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final pass of comments :)
Co-authored-by: Arman Bilge <[email protected]>
Co-authored-by: Arman Bilge <[email protected]>
Co-authored-by: Arman Bilge <[email protected]>
Co-authored-by: Arman Bilge <[email protected]>
Co-authored-by: Arman Bilge <[email protected]>
Co-authored-by: Arman Bilge <[email protected]>
Co-authored-by: Arman Bilge <[email protected]>
Co-authored-by: Arman Bilge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your work on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic, thank you so much :)
Shamelessly inspired from sbt-http4s-org
CirceOrgPlugin
whiich can be used to bring in some common settings amongst projects. Requires you definecirceRootOfCodeCoverage
to eitherNone
for no code coverage, orSome("name-of-root-project")
CirceOrgSitePlugin
which is an attempt at providing a common themse for a gh-pages website. It's currently looking much worse than the original because I'm bad at this. See screenshot in discord channel.Draft description here for historical reasons:
⚠️ Draft PR, description under heavy edit
Shamelessly inspired from sbt-http4s-orgas of now uses onlysbt-typelevel-ci
andsbt-typelevel-settings
. We could also include-site
in this PR, but that might put too much of an early adoption burden on existing projects?addsscalastyle-sbt-plugin
and addssbt-scoverage
with settings that seem to be consistent across existing projectsremovescalastyle-sbt-plugin
, replace with a combo ofscalafmt
andsbt-typelevel-scalafix
TODO:include CirceIoSitePluginalign theme (colors, style, etc) with what we have in the current circe micrositelook for other common settings among projectsactually test this plugin 🙈