Avoid using nohup + monitor "tart run" output using files #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid tainting the passed I/O descriptors.
fkorotkov
reviewed
Jul 17, 2023
internal/tart/vm.go
Outdated
| return filepath.Join(os.TempDir(), fmt.Sprintf("%s-tart-run-output.log", vm.id)) | ||
| } | ||
|
|
||
| func (vm *VM) MonitorOutput() { |
There was a problem hiding this comment.
Let's rename it to MonitorTartRunOutput to be a bit more explicit.
fkorotkov
reviewed
Jul 17, 2023
internal/tart/vm.go
Outdated
| return cmd.Process.Release() | ||
| } | ||
|
|
||
| func (vm *VM) OutputPath() string { |
There was a problem hiding this comment.
Let's rename it to tartRunOutputPath to be a bit more explicit.
fkorotkov
reviewed
Jul 17, 2023
fkorotkov
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nohuperror in Tart execution reports no IP available #30 (comment)tart runprocess is holding GitLab Runner's file descriptors that we passed totart runin hostage (see os/exec: consider changing Wait to stop copying goroutines rather than waiting for them golang/go#23019)vm.MonitorOutput()do not share any state (offset they've last read from the output log file), in case there's an output present the user will see two identical outputs from that file, however, sincetart rungenerally outputs only when something is really wrong, this shouldn't be an issue