Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry DB transactions on badger.ErrConflict #114

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

edigaryev
Copy link
Collaborator

@edigaryev edigaryev commented Aug 15, 2023

To fix the tests in https://cirrus-ci.com/task/5344327489028096 failing because of #114 (comment).

Also log the causes of HTTP 500 errors.

@edigaryev edigaryev requested a review from fkorotkov August 15, 2023 09:15
@edigaryev
Copy link
Collaborator Author

Found the issue: Transaction Conflict. Please retry during POST to /v1/workers.

This is probably caused by a concurrent PUT from an Orchard Worker to /v1/workers/microsun.local.

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

@edigaryev edigaryev changed the title Log HTTP 500 errors in more detail Retry DB transactions on badger.ErrConflict Aug 15, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@edigaryev edigaryev merged commit 036eb95 into main Aug 15, 2023
@edigaryev edigaryev deleted the log-internal-server-errors branch August 15, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants