Never list workers in Update()/storeUpdate() transactions #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edigaryev
force-pushed
the
do-not-list-workers-in-update
branch
from
e223a1a to
08cf668
Compare
fkorotkov
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the high enough number of workers, the probability of conflict of a transaction that lists all workers in the system rises as each worker is concurrently poking the API and updating its
LastSeenfield.We've fixed that for the scheduler in #225, but there's two more places remaining in the codebase:
POST /v1/workers— improved in 6c9b416healthCheckingLoopIteration()— improved in 08cf668