Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LH-73627): Generate Postman Collection #7

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

weilueluo
Copy link
Contributor

@weilueluo weilueluo commented Mar 11, 2024

Description

  • added generate postman collection as part of the cli script
  • generated a postman-collection.json as a one time thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is just ordering changes

Copy link
Contributor

@talhazi talhazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! just wondering how Devnet will pick the postman-collection.json file. don't we need to update the config.json file, or does the devnet just know to pick that file by its name?

@@ -45,6 +46,11 @@
"resolved": "https://registry.npmjs.org/@exodus/schemasafe/-/schemasafe-1.3.0.tgz",
"integrity": "sha512-5Aap/GaRupgNx/feGBwLLTVv8OQFfv3pq2lPRzPg9R+IOBnDgghTGW7l7EuVXOvg5cc/xSAlRW8rBrjIC3Nvqw=="
},
"node_modules/@faker-js/faker": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming - all the new imports are necessary, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I ran a npm ci before commit 🙂

@weilueluo
Copy link
Contributor Author

Really nice! just wondering how Devnet will pick the postman-collection.json file. don't we need to update the config.json file, or does the devnet just know to pick that file by its name?

It is something I need to configure in pubhub, and I will configure it such that it picks up the file of this name

@weilueluo weilueluo merged commit c1dc50b into main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants