Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback for dct:issued and dct:modified in resources #233

Merged

Conversation

seitenbau-govdata
Copy link
Member

@seitenbau-govdata seitenbau-govdata commented Dec 2, 2022

We'd like to add a fallback for the serialization of the resource dates dct:issued and dct:modified, in the same way it is implemented for the dataset. To do so we use the CKAN internal dates created and metadata_modified of the resource.

@seitenbau-govdata seitenbau-govdata marked this pull request as ready for review December 2, 2022 09:03
@amercader
Copy link
Member

This makes sense @seitenbau-govdata , can you merge the latest master branch? that should fix the lint testing issues

@seitenbau-govdata seitenbau-govdata force-pushed the add-fallback-for-resource-dates branch from b56ac69 to 2f22fc3 Compare December 2, 2022 12:08
@seitenbau-govdata seitenbau-govdata force-pushed the add-fallback-for-resource-dates branch from 2f22fc3 to 01d40c5 Compare December 2, 2022 12:18
@seitenbau-govdata
Copy link
Member Author

@amercader Done. The pull request is now based on the current master. Thanks for fixing the testing issues.

@amercader amercader merged commit 9b5dae5 into ckan:master Dec 2, 2022
@seitenbau-govdata seitenbau-govdata deleted the add-fallback-for-resource-dates branch December 2, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants