Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references to each of the parsed access services #251

Merged

Conversation

seitenbau-govdata
Copy link
Member

@seitenbau-govdata seitenbau-govdata commented Jun 1, 2023

The references for dcat:accessService are missing in the profile euro_dcat_ap_2. They are required to enhance the access_services in further profiles by adding more fields.

@seitenbau-govdata
Copy link
Member Author

The tests are currently failing. See #250

@seitenbau-govdata seitenbau-govdata marked this pull request as ready for review June 1, 2023 13:09
@seitenbau-govdata seitenbau-govdata force-pushed the add-references-for-access-services branch from 06f97ac to f7cfe1f Compare June 2, 2023 07:39
@seitenbau-govdata
Copy link
Member Author

seitenbau-govdata commented Jun 7, 2023

@amercader Tests are fine now and the PR is ready for review.

@seitenbau-govdata seitenbau-govdata force-pushed the add-references-for-access-services branch from f7cfe1f to 73da687 Compare June 13, 2023 12:56
@seitenbau-govdata
Copy link
Member Author

I assume @amercader is on vacation. Anyone else have any thoughts about the pull request? They are only minor changes, so if not, the PR will be merged and I will make a new release.

@amercader
Copy link
Member

I wish! Sorry, just have many open fronts now. This looks good, feel free to do a new release

@amercader amercader merged commit 9626b86 into ckan:master Jun 20, 2023
@seitenbau-govdata seitenbau-govdata deleted the add-references-for-access-services branch June 20, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants