Solves URI from contact point #312
Merged
+112
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it make more sense to store |
added 4 commits
October 12, 2024 22:32
…ri-contact-point # Conflicts: # ckanext/dcat/profiles/euro_dcat_ap_scheming.py # ckanext/dcat/tests/profiles/dcat_ap_3/test_euro_dcatap_3_profile_serialize.py
amercader
reviewed
Oct 14, 2024
ckanext/dcat/profiles/base.py
Outdated
| @@ -465,7 +465,8 @@ def _contact_details(self, subject, predicate): | |||
|
|
|||
| for agent in self.g.objects(subject, predicate): | |||
|
|
|||
| contact["uri"] = str(agent) if isinstance(agent, term.URIRef) else "" | |||
| contact["uri"] = (str(agent) if isinstance(agent, URIRef) | |||
| else self._get_vcard_property_value(agent, VCARD.hasUID)) | |||
There was a problem hiding this comment.
Let's keep this as it was and not assign hasUID to uri as discussed.
Otherwise this is good to go
There was a problem hiding this comment.
I reverted this part back and added also the new mapping to the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces functionality to resolve URIs for contact details, specifically targeting the retrieval of more detailed information (e.g., ORCID). Previously, the
contact["uri"]field defaulted to either a string or an empty value. With this update, we attempt to resolve the URI and retrieve associated metadata (e.g.,VCARD.hasUID) when available.Changes:
_contact_detailsmethod to resolve URIs where applicable.URIRef, the system now attempts to fetch theVCARD.hasUIDproperty to enrich the URI field.Benefits: