-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Croissant RecordSet objects #341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For resources that are on the DataStore, we can use `datastore_info` to get a list of the fields present in the data, and expose those as a `RecordSet`. Data types are also included (although these would be all `text` for standard xloader imports) as well as primary keys.
Currently failing because SCHEMA.DateTime is not an expected type??
It sounds really counterintuitive but the validator doesn't like fields with a dataType of DateTime: ``` [Metadata(Test Croissant dataset) > RecordSet(568b8ac9-8c69-4475-b35e-d7f812a63c32/records) > Field()] The field does not specify a valid http://mlcommons.org/croissant/dataType, neither does any of its predecessor. Got: [rdflib.term.URIRef('https://schema.org/DateTime')] ``` Looks like the Date / DateTime situation in schema.org is a bit confusing: schemaorg/schemaorg#1748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the new docs:
DataStore imported tables is the closest that CKAN has right now to a source for identifying the data structure of the data files hosted, and this info really adds value for integration with ML processes and pipelines.
To test this the DataStore needs to be configured and some data imported: