Include dependencies in pyproject, update install docs #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the requirements.txt and dev-requirements.txt around and acting
like the source of truth, o all existing installation processes keep
working as intended but include them dynamically in pyproject.toml to
integrate with modern workflows, and be able to just run
pip install ckanext-dcat
As per these recommendations: ckan/ckan#8382 (comment)
|
Thanks @amercader ! That's pretty cool. We are working on updating to the latest version right now and encountered the same "issues" and solved them as you have now. So we are excitedly awaiting the next release and will update directly to it. 😃 |
|
Then let's wait no more! I think all changes here are improvements and uncontroversial so I'll do a new release now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340
Keep the requirements.txt and dev-requirements.txt around and acting like the source of truth, so all existing installation processes keep working as intended but include them dynamically in pyproject.toml to integrate with modern workflows, and to be able to just run:
The requirements were loosen a bit to adapt to the suggestions by @smotornyuk here:
ckan/ckan#8382 (comment)