Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Add missing apiVersion and kind for PVC #716

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

kahirokunn
Copy link
Contributor

  • Fixes a deployment issue with CD tools like ArgoCD.
  • apiVersion and kind not set in source, causing drift.
  • Ensures consistent state across deployments.
    CleanShot 2025-03-09 at 20 57 41@2x

- Fixes a deployment issue with CD tools like ArgoCD.
- apiVersion and kind not set in source, causing drift.
- Ensures consistent state across deployments.

Signed-off-by: kahirokunn <[email protected]>
Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for kamaji-documentation canceled.

Name Link
🔨 Latest commit 7313ecc
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/67cd824eaa7b690008ea9398

@prometherion
Copy link
Member

Thanks for fixing this, definitely a typo and we already had this on clastix/kamaji-etcd#86.

I'm just wondering why you're using the bare manifests rather than the Helm Chart.

@kahirokunn
Copy link
Contributor Author

kahirokunn commented Mar 10, 2025

I installed Kamaji v1.0.0 using the Helm Chart.
https://kamaji.clastix.io/getting-started/getting-started/

helm repo add clastix https://clastix.github.io/charts
helm repo update
helm install kamaji clastix/kamaji -n kamaji-system --create-namespace

When I encountered the discrepancy during installation, I did a full-text search and found the bare manifests, so I went ahead and opened a PR to address the issue. Could you please let me know when we might expect this fix to be included in the latest Helm Chart release?
clastix/kamaji-etcd#86
Thx 🙏

@prometherion
Copy link
Member

Could you please let me know when we might expect this fix to be included in the latest Helm Chart release?
clastix/kamaji-etcd#86
Thx 🙏

v0.9.2 has been released! :shipit:

@prometherion prometherion merged commit 3865226 into clastix:master Mar 10, 2025
9 checks passed
@kahirokunn
Copy link
Contributor Author

Thank you 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants