Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several (quite important) fixes #73

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

igorsantos07
Copy link

[1] Upgrading computed properties to comply with Ember updates

That piece of code was causing a deprecation warning. See http://emberjs.com/blog/2015/05/13/ember-1-12-released.html#toc_new-computed-syntax

[2] Fixing big problem with custom-named belongsTo relations

A relationship such as problem: DS.belongsTo('item', { async: true }) was being stored with className: 'problem' instead of 'item'.

[3] Fixing id getter on hasMany relations

It seems the id property is not an attribute from the child relation.

@igorsantos07 igorsantos07 changed the title Upgrading CP syntax for Ember 0.12 Several (quite important) fixes Jun 7, 2015
@igorsantos07 igorsantos07 force-pushed the master branch 3 times, most recently from 3eeefd4 to b15b7c6 Compare June 9, 2015 05:22
@mixonic
Copy link
Collaborator

mixonic commented Jul 6, 2015

@igorsantos07 can you squash this to a single commit?

I also believe that the change from snapshot.attr('id') to snapshot.id may not be backwards compatible. Can you confirm what version of ember-data added reading the id directly off the snapshot? That may need to become the version of Ember-Data a next release supports.

@igorsantos07
Copy link
Author

@mixonic I haven't worked on my project for a while, hence this is stopped.
I'll take a look if getAttr() would solve the id issue in any way. I'm not sure anymore why I changed from attr('id') in the first place - and I'm not sure it would be easy to discover when id started to be available :(

Besides that, do you want me to squash all commits into one? I may try but I think some of them are related to different issues, and thus should be separated.

@mixonic
Copy link
Collaborator

mixonic commented Jul 10, 2015

@igorsantos07 the merge commits etc should atleast go away. Please squash as you see fit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants