paredit fns that use internal global-find-by-node do not work after zipper updated

[mrkam2]

Version
rewrite-clj/rewrite-clj {:mvn/version "1.1.47"}

Platform
Clojure version: 1.11.1

Symptom
Two issues:

1. When using rewrite-clj.paredit/kill incorrectly positions the zipper after performing the operation.
2. Docstring says that it should be removing nodes to the right from the current node. But in fact it deletes nodes starting from the current node.

Reproduction

(-> (z/of-string "[1 2 3 4]")
    z/down
    (z/insert-left (n/keyword-node :wrong-pos))
    z/next
    (z/insert-left (n/keyword-node :nil-meta))
    pe/kill
    z/print)
:wrong-pos

Actual behavior

1. Positions zipper on the :wrong-pos.
2. End result is [:wrong-pos 1 :nil-meta ].

Expected behavior

1. Expected to position on 2.
2. Expected end result is [:wrong-pos 1 :nil-meta 2]

Diagnosis

1. Incorrect positioning is caused by global-find-by-node search that compares nodes meta not taking into account that new nodes have nil meta.
2. Either docstring or the behavior needs to be fixed to match each other.

Action
Let me know if a PR is preferred.

[lread]

Thanks @mrkam2!

I can take a peek sometime soon!

[lread]

I'm starting to take a look at this one!

1. I confirm that the kill docstring is wrong and the behavior is correct, barring the new node bug you found.
2. I confirm that kill behavior is broken when new nodes are involved.
3. And yes, anything that uses paredit API's internal global-find-by-node will be broken for newly added nodes.

Thanks again for reporting, @mrkam2. Folks seem to be starting to use the paredit API a bit, and you've uncovered some very interesting flaws.

[lread]

As I fix other issues, I'll update what I've fixed for this issue here:

• join
• kill-one-at-pos
• slurp-forward
• slurp-forward-fully
• slurp-backward
• slurp-backward-fully
• barf-forward
• barf-backward
• splice-killing-forward
• splice-killing-backward
• split-at-pos
• split
• kill
• kill-at-pos