cider-connect: also look for Babashka nrepl servers
#3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
commented
Sep 28, 2023
| (replace-regexp-in-string "^n" "" s)))) | ||
| (seq-filter #'identity) | ||
| car)) | ||
| (port (thread-last (split-string (shell-command-to-string (concat "lsof -n -P -Fn -i -a -p " pid)) |
There was a problem hiding this comment.
added the -P flag, otherwise ports like 1667 would show up as netview-aix-7 since that's "well-known" name.
There was a problem hiding this comment.
Perhaps you can mention this in a comment for future reference.
| (when (string-prefix-p "n" s) | ||
| (replace-regexp-in-string ".*:" "" s)))) | ||
| (seq-filter #'identity) | ||
| (seq-filter (lambda (s) |
There was a problem hiding this comment.
Added some extra filtering, just in case.
bbatsov
reviewed
Sep 29, 2023
cider.el
Outdated
| @@ -1914,29 +1914,34 @@ Use `cider-ps-running-lein-nrepls-command' and | |||
| (unless (eq system-type 'windows-nt) | |||
| (let ((non-lein-nrepl-pids | |||
| (thread-last (split-string | |||
| (shell-command-to-string "ps u | grep java | grep -v leiningen | grep nrepl.cmdline") | |||
| (shell-command-to-string "ps u | grep -E 'java|nrepl.cmdline|--nrepl-server' | grep -v -E 'leiningen|grep'") | |||
There was a problem hiding this comment.
Might be nice to mention in a comment example of things this command is supposed to match. (e.g. using clj and bb)
|
Thanks! All done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bb nrepls look like this in
ps:bb --nrepl-serverA couple other refinements included.
No changelog is needed given there are already improvements under the same category.
Cheers - V