Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish AWS Tag functionality #1257

Merged
merged 12 commits into from
Jul 27, 2024
Merged

Finish AWS Tag functionality #1257

merged 12 commits into from
Jul 27, 2024

Conversation

MZC-CSC
Copy link
Contributor

@MZC-CSC MZC-CSC commented Jul 25, 2024

Finished tagging and lookup checks on each handler's Create and Get function calls.
If the request value is not tagged with a Name, it automatically uses the NameId value of the IID.

  • ClusterHandler
  • DiskHandler
  • KeyPairHandler
  • MyImageHandler
  • NLBHandler
  • SecurityHandler
  • VMHandler
  • VPCHandler

TagHandler feature fixed and tested

  • Added and tested ListTag / GetTag / AddTag / RemoveTag / FindTag features for Cluster and NLB
  • Bug fixes due to special behavior of KeyPair

Copy link

Could you please check and revise Korean texts?
Note - All output of print and log statements should be in English. 😉

cloud-control-manager/cloud-driver/drivers/aws/main/Test_Resources.go

27:+					cblogger.Error(reqPublicIP, " PublicIP 정보 Lookup Failed : ", err)
28:+					cblogger.Infof("PublicIP[%s]  정보 Lookup Result", reqPublicIP)
30:+					cblogger.Info("PublicIP 생성 Success ", result)

@powerkimhub powerkimhub self-requested a review July 25, 2024 08:33
@powerkimhub powerkimhub merged commit 0634696 into cloud-barista:master Jul 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants