Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NHN: Improve NHN source codes #1261

Merged
merged 10 commits into from
Aug 2, 2024
Merged

Conversation

ish-hcc
Copy link
Member

@ish-hcc ish-hcc commented Jul 29, 2024

NHN

  • Make possible to control all of supported resources by name ID
  • Apply the same test code structure as other CSPs (Test_Resources.go)

@ish-hcc
Copy link
Member Author

ish-hcc commented Aug 1, 2024

@powerkimhub @innodreamer
반영이 언제쯤 되는지 알 수 있을까요?

@powerkimhub
Copy link
Member

@ish-hcc

  • 전체적으로 driver 내부 로직만 변경된거라 볼수 있나요?
  • Driver API 활용하는 Spider 서버에 영향을 주는 부분은 없을 지 문의 드립니다.
  • 혹시, 그렇다면 AdminWeb이나 Rest API를 이용한 테스트도 진행이 된 부분인 지도 문의 드립니다.

@powerkimhub powerkimhub self-requested a review August 1, 2024 23:15
@ish-hcc
Copy link
Member Author

ish-hcc commented Aug 2, 2024

@powerkimhub

  • 네 드라이버 내부에서만 이름으로 리소스를 찾을수 있도록 수정되었습니다.
  • CLI 상으로는 모든 자원에 대해서 생성/조회/삭제, 노드그룹 추가/변경/삭제 테스트 완료했습니다. (Test_Resources.go 활용)
  • Admin Web 상으로는 PMKS 에서 클러스터 생성시 노드 그룹 지정이 필요하다는 에러가 반환되어 해당 부분을 제외하고는 모두 정상 생성/조회/삭제 확인했습니다

@powerkimhub powerkimhub merged commit 38baf5d into cloud-barista:master Aug 2, 2024
3 checks passed
@ish-hcc ish-hcc deleted the fix_nhn branch September 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants