Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack:Fix Floating IP #1456

Merged
merged 2 commits into from
Feb 6, 2025
Merged

OpenStack:Fix Floating IP #1456

merged 2 commits into from
Feb 6, 2025

Conversation

suahlingo
Copy link
Member

No description provided.

@powerkimhub powerkimhub linked an issue Feb 6, 2025 that may be closed by this pull request
[OpenStack:VM] Uncontrolled Floating IP #1439
Closed
@powerkimhub powerkimhub merged commit 31d0a8f into cloud-barista:master Feb 6, 2025
3 checks passed
@powerkimhub
Copy link
Member

@suahlingo


[현황]

  • 패치 해주신 버전을 시험해보니,
  • 여전히 Floating IP가 잔존하고 있는 상태였습니다.
  • 아마도, 상황 재현이 안되어 시험/확인이 힘드셨을 걸로 예상됩니다.

[분석]

  • 다음, defer func(publicIP string)에서 publicIP 인자가 새로 생성되는 local 변수로서,
    • 항상 "" 값이 유지되어 ip가 clean되고 있지 않았습니다.
defer func(publicIP string) {
              ...
	}(publicIPStr)

[반영]

  • trace한 김에 간단하여서 바로 반영하였습니다.
  • 현황 공유 드립니다.
  • 9bd1392

powerkimhub referenced this pull request Feb 7, 2025
@powerkimhub
Fix the defer function in StartVM() to delete unassociated FloatingIP
9bd1392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerkimhub powerkimhub powerkimhub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OpenStack:VM] Uncontrolled Floating IP
2 participants
@suahlingo @powerkimhub