Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Support For Custom Hostname Creation Properties #177

Closed
phily245 opened this issue Jun 14, 2021 · 0 comments · Fixed by #178
Closed

Missing Support For Custom Hostname Creation Properties #177

phily245 opened this issue Jun 14, 2021 · 0 comments · Fixed by #178

Comments

@phily245
Copy link
Contributor

phily245 commented Jun 14, 2021 •
edited
Loading

When creating a custom hostname using the addHostname function at https://github.com/cloudflare/cloudflare-php/blob/master/src/Endpoints/CustomHostnames.php#L38, there is no support for the bundle_method, custom_certificate or custom_key fields as documented at https://api.cloudflare.com/#custom-hostname-for-a-zone-create-custom-hostname.

I will make a PR for this.
@phily245 phily245 mentioned this issue Jun 14, 2021
Merged
@phily245 phily245 changed the title Missing Support For Custom Hostname Properties Missing Support For Custom Hostname Creation Properties Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Missing Support For Custom Hostname Properties phily245/cloudflare-php
1 participant
@phily245