Add Missing Support For Custom Hostname Properties #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now matches what is available as per the documentation
I've added a few new parameters which has made these lines rather long
|
I used TDD on this so I haven't tested yet, but I suspect the options are in the wrong place according to the docs. I'll fix this tomorrow. |
This wasn't taking affect before as it wasn't in the object the API was expecting it to be in
I was right, testing this on live proved that not only my options were at the wrong level, but the wildcard flag was too (as they're all the same level in the docs). I've pushed a fix for this |
|
I'm happy to review these PRs you've raised if you fix those lint failures in CI |
This was asked for in a CR
Thank you, I can look at this today 😄 |
This was my bad
This kinda kicks the can down the road, but allows me to appease PHPMD (for now)
This was a good spot, as I can reuse this declaration in another PR
I needed to trigger a github action after a network timeout
…github.com:phily245/cloudflare-php into 177-missing-support=for=custom-hostname-properties
This reverts commit ed822d1.
This reverts commit 969fc8c.
|
@jacobbednarz the failing lint has been addressed |
|
awesome, thanks! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #177, there are some missing properties from custom hostname creation (shown at https://api.cloudflare.com/#custom-hostname-for-a-zone-create-custom-hostname). This PR attempts to add these in.
Closes #177