Add Account Id To Zone Creation #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the docs, this is a required parameter
The linter correctly pointed out that we had too many public methods on this class
TY linter
src/Endpoints/Zones.php
Outdated
| @@ -30,7 +30,7 @@ public function __construct(Adapter $adapter) | |||
| * @param string $organizationID | |||
| * @return \stdClass | |||
| */ | |||
| public function addZone(string $name, bool $jumpStart = false, string $organizationID = ''): \stdClass | |||
| public function addZone(string $name, bool $jumpStart = false, string $organizationID = '', string $accountId = ''): \stdClass | |||
There was a problem hiding this comment.
here, organizationID is the same as accountID; the terminology has just changed internally to better represent the entity. i'm happy to support a rename here instead.
There was a problem hiding this comment.
Thanks for the heads up! I've pushed some changes and left the organization->id setting in the body for backwards compatibility
This was a misunderstanding by me, these are actually the same thing
I missed updating this in my previous commit
I didn't remove the extra parameter I added earlier due too a terminology change
It seems accounts have superceeded this
|
@jacobbednarz thanks for all the feedback! I think I've addressed everything |
|
awesome stuff! thanks! |
phily245
deleted the
189-Allow-Passing-Of-An-Account-ID-To-Zone-Creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs, this is a required parameter.
Closes #189