Add Zone Subscription Creation #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consuming the tenant API requires this as a part of the provisioning
phily245
commented
Oct 4, 2021
| $this->adapter = $adapter; | ||
| } | ||
|
|
||
| public function addZoneSubscription(string $zoneId, string $ratePlanId = ''): stdClass |
There was a problem hiding this comment.
just a little heads up that the method isn't always POST. see https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/cloudflare/resource_cloudflare_zone.go#L217-L228 for some logic and comments around the behaviour.
There was a problem hiding this comment.
I think I've matched this with my latest commits
There was a problem hiding this comment.
@jacobbednarz thanks for all the feedback! I think I've addressed this, but it would probably be worth you double checking as golang (from your terraform sample) isn't a language I use every day
I copy/pasted this from elsewhere
This will handle updating the subscription regardless of if the subscription exists or not
This isn't supported in <= 7.2, I was using PHP 7.4 to develop this but CI handily highlighted this
| } | ||
|
|
||
| $existingSubscription = $this->listZoneSubscriptions($zoneId); | ||
| $method = empty($existingSubscription->result) ? 'post' : 'put'; |
There was a problem hiding this comment.
heh, this is one way of checking it 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consuming the tenant API requires this as a part of the provisioning.
Closes #190