-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Waku to C3 #8314
base: main
Are you sure you want to change the base?
feat: add Waku to C3 #8314
Conversation
|
8aa5ca3
to
d1ff8ba
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-wrangler-8314 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8314/npm-package-wrangler-8314 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-wrangler-8314 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workers-bindings-extension-8314 -O ./cloudflare-workers-bindings-extension.0.0.0-veb635466b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-veb635466b.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-create-cloudflare-8314 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-kv-asset-handler-8314 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-miniflare-8314 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-pages-shared-8314 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-unenv-preset-8314 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-vite-plugin-8314 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-vitest-pool-workers-8314 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workers-editor-shared-8314 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workers-shared-8314 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workflows-shared-8314 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
0f68d70
to
ce7fa61
Compare
@@ -0,0 +1,24 @@ | |||
#:schema node_modules/wrangler/config-schema.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you be able to make this a wrangler.jsonc? for consistency :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! I didn't see that the other templates started migrating. I'll get that updated in the Cloudflare Waku template and also rebase to fix the new conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. That is all set in this PR. I also submitted an upstream PR to switch to wrangler.jsonc and to recognize an existing toml, json or jsonc file. dai-shi/waku#1301
Fixes cloudflare#7594. Adding a C3 template for Waku, a minimal React framework. https://waku.gg/ - Tests - [ ] TODO (before merge) - [x] Tests included - [ ] Tests not necessary because: - E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately) - [ ] I don't know - [x] Required - [ ] Not required because: - Public documentation - [ ] TODO (before merge) - [x] Cloudflare docs PR(s): <cloudflare/cloudflare-docs#20444> - [ ] Documentation not necessary because:
ce7fa61
to
9d9952b
Compare
Cloudflare is using jsonc as the default config format for their templates: [workers-sdk#8314](cloudflare/workers-sdk#8314 (review)). https://developers.cloudflare.com/workers/wrangler/configuration/
Fixes #7594.
Adding a C3 template for Waku, a minimal React framework. https://waku.gg/