Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Waku to C3 #8314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmarscher
Copy link

@rmarscher rmarscher commented Mar 1, 2025

Fixes #7594.

Adding a C3 template for Waku, a minimal React framework. https://waku.gg/

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation

@rmarscher rmarscher requested review from a team as code owners March 1, 2025 17:03
Copy link

changeset-bot bot commented Mar 1, 2025

⚠️ No Changeset found

Latest commit: ce7fa61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 6, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-wrangler-8314

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8314/npm-package-wrangler-8314

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-wrangler-8314 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workers-bindings-extension-8314 -O ./cloudflare-workers-bindings-extension.0.0.0-veb635466b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-veb635466b.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-create-cloudflare-8314 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-kv-asset-handler-8314

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-miniflare-8314

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-pages-shared-8314

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-unenv-preset-8314

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-vite-plugin-8314

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-vitest-pool-workers-8314

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workers-editor-shared-8314

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workers-shared-8314

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workflows-shared-8314

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250224.0
workerd 1.20250224.0 1.20250224.0
workerd --version 1.20250224.0 2025-02-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@rmarscher rmarscher force-pushed the c3-framework-experimental-waku branch 2 times, most recently from 0f68d70 to ce7fa61 Compare March 6, 2025 13:25
@@ -0,0 +1,24 @@
#:schema node_modules/wrangler/config-schema.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you be able to make this a wrangler.jsonc? for consistency :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely! I didn't see that the other templates started migrating. I'll get that updated in the Cloudflare Waku template and also rebase to fix the new conflicts.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. That is all set in this PR. I also submitted an upstream PR to switch to wrangler.jsonc and to recognize an existing toml, json or jsonc file. dai-shi/waku#1301

Fixes cloudflare#7594.

Adding a C3 template for Waku, a minimal React framework. https://waku.gg/

- Tests
  - [ ] TODO (before merge)
  - [x] Tests included
  - [ ] Tests not necessary because:
- E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  - [ ] I don't know
  - [x] Required
  - [ ] Not required because:
- Public documentation
  - [ ] TODO (before merge)
  - [x] Cloudflare docs PR(s): <cloudflare/cloudflare-docs#20444>
  - [ ] Documentation not necessary because:
@rmarscher rmarscher force-pushed the c3-framework-experimental-waku branch from ce7fa61 to 9d9952b Compare March 8, 2025 06:41
dai-shi pushed a commit to dai-shi/waku that referenced this pull request Mar 8, 2025
Cloudflare is using jsonc as the default config format for their
templates:
[workers-sdk#8314](cloudflare/workers-sdk#8314 (review)).

https://developers.cloudflare.com/workers/wrangler/configuration/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Add Waku to c3 framework experimental templates
3 participants