Remove special short timeout used for the agent_client during cck #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been there since 2011 but we had reports that jobs will sometimes fail when performing a CCK that succeed just fine during a normal deploy. We traced this down to CCK having a shorter timeout and fewer retries but can't find any good justification for this difference in agent_client behavior. Signed-off-by: Joseph Palermo <[email protected]>
beyhan
requested review from
a team,
xtreme-nitin-ravindran and
a-hassanin
and removed request for
a team
aramprice
approved these changes
Feb 20, 2025
benjaminguttmann-avtq
approved these changes
Feb 21, 2025
ystros
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been there since 2011 but we had reports that jobs will sometimes fail when performing a CCK that succeed just fine during a normal deploy. We traced this down to CCK having a shorter timeout and fewer retries but can't find any good justification for this difference in agent_client behavior.